Add recordings/compositions endpoint #27
Conversation
omi_api/views/compositions.py
Outdated
| @@ -39,6 +39,8 @@ def post(self): | |||
| location='json') | |||
| parser.add_argument('publishers', type=list, required=True, | |||
| location='json') | |||
| parser.add_argument('iswc', type=str, required=True, | |||
There was a problem hiding this comment.
I'll make required=False. However, then matching recordings and compositions won't work for this implementation.
@vrde and I talked.
omi_api/queries.py
Outdated
|
|
||
|
|
||
| def unpack(doc): | ||
| return doc['block']['transactions']['asset']['data'] |
There was a problem hiding this comment.
For prosperity: One must be able to do this in a MDB query directly 🤔
omi_api/utils.py
Outdated
| @@ -19,5 +19,6 @@ def get_bigchaindb_api_url(): | |||
| def queryparams_to_dict(queryparams): | |||
| queryparams = dict(queryparams) | |||
| for k, v in queryparams.items(): | |||
| queryparams[k] = v[0] | |||
| if v: | |||
There was a problem hiding this comment.
Oh thanks! I remember thinking about this during implementation. Then I forgot.
| bdb = BigchainDB(get_bigchaindb_api_url()) | ||
|
|
||
| recordings_compositions_views = Blueprint('recordings_compositions_views', | ||
|
|
There was a problem hiding this comment.
rm line? @vrde I can do it; or was it intentional?
| return 'Composition and Recording were successfully connected.', 200 | ||
|
|
||
|
|
||
| recordings_compositions_api.add_resource( |
There was a problem hiding this comment.
We also need an /compositions/recordings endpoint. I imagine that is not a lot of work (same functionality can be reused).
There was a problem hiding this comment.
It's not a lot of work, it's actually just one line to implement this. I didn't do it yet because I didn't want to diverge from the specs too much.
|
|
||
| tx = bdb.transactions.prepare( | ||
| operation='CREATE', | ||
| signers=config.PUBLIC_KEY, |
There was a problem hiding this comment.
When #26 is merged, we should adjust this.
| signers=config.PUBLIC_KEY, | ||
| asset={'data': link}) | ||
|
|
||
| signed_tx = bdb.transactions.fulfill(tx, private_keys=config.PRIVATE_KEY) |
There was a problem hiding this comment.
When #26 is merged, we should adjust this.
TimDaub
force-pushed
the
add-recording-composition-endpoint
branch
from
184423f to
54ec470
Compare
Add
recordings/compositionsendpoint to:isrcandiswccodes.